Mohamed Boucadair has entered the following ballot position for draft-ietf-emu-eap-edhoc-10: No Objection
When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-emu-eap-edhoc/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Hi Dan, Rafael, Göran, John, and Francisco, Thank you for the effort put into this document. # I agree with Éric comments. # I think Peer/Server roles would be better if introduced in the terminology section. # Set ambiguity: clarify that this means set to 1 The text uses “set to 0”, “set to 1”, “set”, etc. Some clarity can be done in the convention section by indicating how “set” should be interpreted. Alternatively, consider changes such as: OLD: The S flag bit SHALL be set in the EAP-EDHOC Start message sent by the EAP server to the peer. The S flag bit SHALL NOT be set in any other EAP-EDHOC messages. The M flag bit SHALL be set in all fragments except the last one. NEW: The S flag bit SHALL be set to 1 in the EAP-EDHOC Start message sent by the EAP server to the peer. The S flag bit SHALL NOT be set to 1 in any other EAP-EDHOC messages. The M flag bit SHALL be set to 1 in all fragments except the last one. OLD: The M bit (more fragments) is set on NEW: The M bit (more fragments) is set to 1 There are many such occurrences. # Future use CURRENT: Values from 5 to 7 are not used in this specification. Are these values reserved and available for future assignment? # You may find some nits that I flagged when reading the document [1]. Cheers, Med [1] https://github.com/dangarciacarrillo/i-d-eap-edhoc/pull/14 _______________________________________________ Emu mailing list -- [email protected] To unsubscribe send an email to [email protected]
