On 02/15/2012 10:26 AM, Yaniv Kaul wrote:
Since regretfully there was no time for my topic, I'll convey it via
email.
I'd like to suggest 3 simple rules to assist in keeping the projects
stable:
1. If you've broken the Jenkins automated tests, provide a fix ASAP.
2. Don't fix what's ain't broken.
3. Follow rules 1 & 2 at all times.
Thanks,
Y.
Since we are engineers we can start numbering at zero:
0. Don't push anything that you know will cause test failures or won't
compile.
Every commit point is publicly available and any member of the community
might grab oVirt at your broken commit point. When they fail to build
it makes the project look unprofessional and immature.
+1 to #1
-1 to #2 - code needs to be fluid and flexible. A bias against
proactive refactoring tends to lead to code that is brittle and
eventually unmaintainable.
I'd like to add to that:
If you give at patch the verified flag this implies that you have:
1. pulled the patch locally and ensured that it builds
2. have run all the unit tests and ensure that they all pass
If either of these are not true, you need to give the patch "-1 Fails"
If you don't do this you are as much to blame as the author.
On 02/15/2012 03:51 PM, Livnat Peer wrote:
On 15/02/12 13:39, Eyal Edri wrote:
----- Original Message -----
From: "Yaniv Kaul"<[email protected]>
To: "Livnat Peer"<[email protected]>
Cc: [email protected]
Sent: Wednesday, February 15, 2012 1:35:56 PM
Subject: Re: [Engine-devel] agenda for today's meeting
On 02/15/2012 01:21 PM, Livnat Peer wrote:
Hi All,
Agenda for this week meeting:
- Implementation of bridged networks
- Clone Vm from snapshot
- Automatic recovery of entities
Thanks, Livnat
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
If there's time, I'd be happy to add another topic to the agenda:
- upstream stabilization (especially considering the recent failures
in
unit tests)
Y.
+1.
This was added to agenda.
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
