note: i partly changed it in [1] fixing bug. [1] http://gerrit.ovirt.org/#change,4572
On 05/20/2012 05:22 PM, Michael Kublin wrote: > Yep, it is should be id, I aware about these and Ori already asked me to > change it, I will change these very soon > > ----- Original Message ----- > From: "Michael Pasternak" <[email protected]> > To: "Yair Zaslavsky" <[email protected]> > Cc: "Michael Kublin" <[email protected]>, "engine-devel" > <[email protected]> > Sent: Sunday, May 20, 2012 5:08:22 PM > Subject: Re: DiskImage public mapper > > On 05/20/2012 04:55 PM, Michael Kublin wrote: >> both, id - it is a common id for all images that a disk point of them, and >> ImageId it is a current image > > if so i have doubts about cloning vm from template impl, as parameters class > in BackendVmsResource:182 > that receives HashMap<Guid, DiskImage> as collection of disks to clone has > "current image" id as key, > > Yair shouldn't it be /id/ rather than /ImageId/? > >> >> ----- Original Message ----- >> From: "Michael Pasternak" <[email protected]> >> To: "Michael Kublin" <[email protected]>, "Yair Zaslavsky" >> <[email protected]> >> Cc: "engine-devel" <[email protected]> >> Sent: Sunday, May 20, 2012 4:57:13 PM >> Subject: DiskImage public mupper >> >> what should be exposed to user as disk.id: DiskImage.id or DiskImage.ImageId >> ? > > -- Michael Pasternak RedHat, ENG-Virtualization R&D _______________________________________________ Engine-devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-devel
