----- Original Message -----
From: "Eli Mesika" <[email protected]>
To: "Allon Mureinik" <[email protected]>
Cc: "Liron Aravot" <[email protected]>, "Federico Simoncelli" 
<[email protected]>, "engine-devel" <[email protected]>, "Eduardo 
Warszawski" <[email protected]>, "Yeela Kaplan" <[email protected]>
Sent: Friday, August 10, 2012 3:40:48 AM
Subject: Re: [Engine-devel] Serial Execution of Async Tasks



----- Original Message -----
> From: "Allon Mureinik" <[email protected]>
> To: "engine-devel" <[email protected]>
> Cc: "Eduardo Warszawski" <[email protected]>, "Yeela Kaplan" 
> <[email protected]>, "Federico Simoncelli"
> <[email protected]>, "Liron Aravot" <[email protected]>
> Sent: Thursday, August 9, 2012 6:41:09 PM
> Subject: [Engine-devel] Serial Execution of Async Tasks
> 
> Hi guys,
> 
> As you may know the engine currently has the ability to fire an SPM
> task, and be asynchronously be "woken-up" when it ends.
> This is great, but we found the for the Live Storage Migration
> feature we need something a bit complex - the ability to have a
> series of async tasks in a single control flow.
> 
> Here's my initial design for this, your comments and criticism would
> be welcome:
> http://wiki.ovirt.org/wiki/Features/Serial_Execution_of_Asynchronous_Tasks_Detailed_Design

Apart from the short explanation & flow , since this is a detailed design , I 
would add
1) Class diagram
2) Flow diagram 

+1
I am also interested to get a flow how a task is created (i.e - replacement of 
ConcreateCreateTask) - but this will be handled in what Eli has asked for.

In addition, you have two titles of  "Successful Execution".
At "compensate" - see how revertTasks currently behaves.
Also read -
http://wiki.ovirt.org/wiki/Main_Page/features/RunningCommandsOnEndActionFailure

This is the work I did for CloneVmFromSnapshot - not saying it's perfect - but 
you should have an infrastructure/pattern to rollback not just via 
spmRevertTask but also using an engine command.

Yair



> 
> 
> -Allon
> _______________________________________________
> Engine-devel mailing list
> [email protected]
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________
Engine-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-devel

Reply via email to