----- Original Message ----- > From: "Omer Frenkel" <[email protected]> > To: "Michael Kublin" <[email protected]> > Cc: "engine-devel" <[email protected]> > Sent: Sunday, February 3, 2013 3:12:19 PM > Subject: Re: [Engine-devel] Guid & NGuid > > > > ----- Original Message ----- > > From: "Michael Kublin" <[email protected]> > > To: "engine-devel" <[email protected]> > > Sent: Sunday, February 3, 2013 3:10:14 PM > > Subject: [Engine-devel] Guid & NGuid > > > > Hi, > > > > In ovirt-engine code we have Guid and NGuid objects. > > Guid is extends NGuid and also NGuid class has method getValue() > > which should return Guid. > > As for me these two classes are look like the same and I don't see > > to > > much differences between them. > > My proposal is to remove NGuid and move it functionality to Guid > > (Because of Guid is much more common) > > > > i agree, but we need to take another step forward and allow Guid to > be null (as it should) > and not assume its EMPTY or have a value (i'm pretty sure we have > this assumption in many places)
+1 NGuid IIRC was introduced for nullable GUID (i.e - Integer vs int ) I guess this was created back at the porting days, and now we don't need it, as non primitives can always be nullable. > > > Regards Michael > > _______________________________________________ > > Engine-devel mailing list > > [email protected] > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/engine-devel > _______________________________________________ Engine-devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-devel
