> ----- Original Message ----- > From: "Allon Mureinik" <amure...@redhat.com> > Sent: Tuesday, April 9, 2013 4:46:58 AM > > OK, patch is merged (thanks kind reviewers!) > > Einav - please check that this also solves the issue in /your/ setup and let > us all know.
Hi Allon, I apologize for my late answer - I just took latest upstream and compilation including tests has passed successfully - many thanks for your prompt and helpful response - I appreciate it! > > > Thanks, > Allon > > ----- Original Message ----- > > From: "Allon Mureinik" <amure...@redhat.com> > > To: "Einav Cohen" <eco...@redhat.com> > > Cc: "engine-devel" <engine-devel@ovirt.org> > > Sent: Tuesday, April 9, 2013 10:24:02 AM > > Subject: Re: [Engine-devel] compilation stuck on RemoveSnapshotCommandTest? > > > > The last message would have been much more useful if I'd actually attached > > the link to my patch: > > http://gerrit.ovirt.org/#/c/13733/ > > > > Note that it is /not/ merge yet - review would be appreciated. > > ----- Original Message ----- > > > From: "Allon Mureinik" <amure...@redhat.com> > > > To: "Einav Cohen" <eco...@redhat.com> > > > Cc: "engine-devel" <engine-devel@ovirt.org> > > > Sent: Tuesday, April 9, 2013 10:22:38 AM > > > Subject: Re: [Engine-devel] compilation stuck on > > > RemoveSnapshotCommandTest? > > > > > > OK, my guess is that test uses Mockito Matchers carelessly. > > > > > > I removed them, and on my setup I reduced the time it takes to run this > > > test > > > alone in eclipse from ~70 seconds to ~0.7 seconds (i.e., removed 99% of > > > the > > > runtime). > > > > > > Please check it solves the issue on your setup too. > > > > > > > > > Thanks, > > > Allon > > > > > > ----- Original Message ----- > > > > From: "Allon Mureinik" <amure...@redhat.com> > > > > To: "Einav Cohen" <eco...@redhat.com> > > > > Cc: "engine-devel" <engine-devel@ovirt.org> > > > > Sent: Tuesday, April 9, 2013 9:39:41 AM > > > > Subject: Re: [Engine-devel] compilation stuck on > > > > RemoveSnapshotCommandTest? > > > > > > > > When running [1] on this morning's master (commit hash eca9964, merged > > > > April > > > > 8th, 20:15 IST) I didn't notice any issues (built the entire project in > > > > ~3 > > > > minutes, backend took 27 seconds), but when running this test alone in > > > > eclipse it definitely took much longer. > > > > > > > > I'm guessing it lacks some mocking, which some earlier test is doing by > > > > mistake. > > > > Since JUnit does not enforce any ordering, we may be running our tests > > > > in > > > > a > > > > slightly different order (due to different maven/java/os minor > > > > versions, > > > > etc.), which makes the problem visible on your setup but not mine. > > > > > > > > I'll do somemore digging and see if I can pinpoint it. > > > > > > > > ----- Original Message ----- > > > > > From: "Einav Cohen" <eco...@redhat.com> > > > > > To: "engine-devel" <engine-devel@ovirt.org> > > > > > Sent: Monday, April 8, 2013 6:35:47 PM > > > > > Subject: [Engine-devel] compilation stuck on > > > > > RemoveSnapshotCommandTest? > > > > > > > > > > Hi, > > > > > > > > > > When trying to compile oVirt (with tests - see [1]), my compilation > > > > > seems > > > > > to > > > > > get stuck on > > > > > RemoveSnapshotCommandTest (see [2] for test file full path, [3] for > > > > > output). > > > > > > > > > > When eliminating this test (e.g. I removed [2] locally from my > > > > > file-system), > > > > > compilation > > > > > (including tests) is completed successfully. > > > > > > > > > > Anyone else encountered this problem / any idea what the problem > > > > > might > > > > > be? > > > > > > > > > > ---- > > > > > Thanks, > > > > > Einav > > > > > > > > > > > > > > > [1] performed the following on the latest upstream: > > > > > mvn clean > > > > > mvn install -Pgwt-user,gwt-admin,all-langs -Dgwt.userAgent=gecko1_8 > > > > > > > > > > [2] > > > > > ../backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java > > > > > > > > > > [3] last lines in compilation output: > > > > > ... > > > > > [INFO] > > > > > ------------------------------------------------------------------------ > > > > > [INFO] Building Backend Logic @Service bean 3.3.0-SNAPSHOT > > > > > [INFO] > > > > > ------------------------------------------------------------------------ > > > > > ... > > > > > > > > > > Running > > > > > org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest > > > > > Tests run: 56, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.74 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.cluster.GetAllNetworksByClusterIdQueryTest > > > > > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.064 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.cluster.AttachNetworkToVdsGroupCommandTest > > > > > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.046 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.cluster.NetworkClusterValidatorTest > > > > > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.cluster.GetVdsGroupsAndNetworksByNetworkIdQueryTest > > > > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.vm.GetVmInterfacesByVmIdQueryTest > > > > > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.042 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.vm.GetVmsAndNetworkInterfacesByNetworkIdQueryTest > > > > > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.056 > > > > > sec > > > > > Running org.ovirt.engine.core.bll.network.VmInterfaceManagerTest > > > > > Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > > > > > 0.321 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.template.GetTemplateInterfacesByTemplateIdQueryTest > > > > > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.02 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.network.template.GetVmTemplatesAndNetworkInterfacesByNetworkIdQueryTest > > > > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.GetCommandsCompatibilityVersionsQueryTest > > > > > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.09 > > > > > sec > > > > > Running > > > > > org.ovirt.engine.core.bll.GetClustersWithPermittedActionQueryTest > > > > > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 > > > > > sec > > > > > Running org.ovirt.engine.core.bll.RemoveSnapshotCommandTest > > > > > [no more output after this point; waited ~20 minutes in this state > > > > > before > > > > > hitting "Ctrl+C"] > > > > > _______________________________________________ > > > > > Engine-devel mailing list > > > > > Engine-devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > _______________________________________________ > > > > Engine-devel mailing list > > > > Engine-devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > _______________________________________________ > > Engine-devel mailing list > > Engine-devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ > Engine-devel mailing list > Engine-devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
