Following this short vote, I have decided to adopt an approach in which we will use findbugs with the maven plugin on a per module basis, as some of you have suggested. An example for bll can be found here -
http://gerrit.ovirt.org/#/c/14110/3 ----- Original Message ----- > From: "Michael Pasternak" <[email protected]> > To: "Oved Ourfalli" <[email protected]> > Cc: "Yair Zaslavsky" <[email protected]>, "engine-devel" > <[email protected]> > Sent: Thursday, April 18, 2013 9:33:34 PM > Subject: Re: [Engine-devel] Location of findbugs filter.xml file > > On 04/18/2013 04:58 PM, Oved Ourfalli wrote: > > > > > > ----- Original Message ----- > >> From: "Yair Zaslavsky" <[email protected]> > >> To: "engine-devel" <[email protected]> > >> Sent: Thursday, April 18, 2013 4:55:46 PM > >> Subject: [Engine-devel] Location of findbugs filter.xml file > >> > >> Hi all, > >> I sent a patch upstream to add findbugs filter that will filter out bug > >> reports that we decided that are not bugs. > >> We have a debate on whether to have the findbugs filter definition in the > >> root pom.xml or to put it in the jenkins jobs repo and treat it as an > >> external tool. > >> I would like to hear opinions about what you think should be the proper > >> location > >> > > Putting it in the root pom.xml file will allow running filtered findbugs > > using maven, without the need to use jenkins, so I'd go with that > > approach. > > +1 > > > > >> Thanks, > >> Yair > >> _______________________________________________ > >> Engine-devel mailing list > >> [email protected] > >> http://lists.ovirt.org/mailman/listinfo/engine-devel > >> > > _______________________________________________ > > Engine-devel mailing list > > [email protected] > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > -- > > Michael Pasternak > RedHat, ENG-Virtualization R&D > _______________________________________________ Engine-devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-devel
