Hi all,
Thanks to Alon Bar Lev's efforts for preventing to concurrent host installation 
for the same host entity + Roy Golan's check of the code, we saw that for 
commands that override

getExclusiveLocks() or getSharedLocks() the locking mechanism does not work 
(lock is not being acquired) if there is no annotation of @LockIdNameAttribute 
on the class.
A bug was filed for removing this annotation (leftover from some historical 
code ) , but until it is fixed - bare in mind you need to add this annotation 
in current commands you are working on 
in order to utilize the mechanism.
See RemoveVmCommand (has the annotation) vs AddDiskCommand (which doesn't have 
the annotation)


Cheers,
Yair
_______________________________________________
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel

Reply via email to