Hi Jason, Please reply on the comments in the patch. Once the code is written I think it's better not to context switch back to the design. we will reach an agreement in gerrit/review and then update the design respectively.
Thanks, Gilad. ----- Original Message ----- > From: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.l...@hp.com> > To: "Gilad Chaplik" <gchap...@redhat.com> > Cc: "Doron Fediuck" <dfedi...@redhat.com>, "Chegu Vinod" > <chegu_vi...@hp.com>, "Martin Sivak" <msi...@redhat.com>, > "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <xiao-lei....@hp.com>, "Shang-Chun > Liang (David Liang, > HPservers-Core-OE-PSC)" <shangchun.li...@hp.com>, engine-devel@ovirt.org > Sent: Monday, March 31, 2014 7:48:28 PM > Subject: RE: Numa feature entities patch > > Hi Gilad, > > I have update the wiki page design of BE patch > 1. add VdcQueryType and VdcActionType with parameters. > 2. merge some of your comments and Eli's feedback. > > Please take a look at the section > http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA#Interface_and_data_structure_in_engine_core > > We appreciate any of the comments from community, and sorry for the nag. > > Best Regards, > Jason Liao > > -----Original Message----- > From: Gilad Chaplik [mailto:gchap...@redhat.com] > Sent: 2014年3月30日 22:43 > To: Liao, Chuan (Jason Liao, HPservers-Core-OE-PSC); Shi, Xiao-Lei (Bruce, HP > Servers-PSC-CQ); Liang, Shang-Chun (David Liang, HPservers-Core-OE-PSC) > Cc: Doron Fediuck; Vinod, Chegu; Martin Sivak > Subject: Numa feature entities patch > > Hi all, > > I had some comments :-) IMO this patch [1] has maximum priority. > let's try to merge it ASAP, I will be very responsive to every new upload. > > Thanks, > Gilad. > > [1] http://gerrit.ovirt.org/#/c/23702/ > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel