Itamar Heim has posted comments on this change.
Change subject: engine : Hotplug feature - db scripts
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File backend/manager/dbscripts/images_sp.sql
Line 107: propagate_errors = v_propagate_errors,
this is whitespace noise unrelated to the patch?
....................................................
File backend/manager/dbscripts/image_vm_map_sp.sql
Line 27: v_plugged BOOLEAN)
aren't we differentiating between the current status and the configuration
status (what should happen at next vm start)?
....................................................
File backend/manager/dbscripts/upgrade/03_01_0130_plugged_config_options.sql
Line 2: select fn_db_add_config_value('HotPlugEnabled','true','3.1');
hot plug disk? nic? cpu? memory?
--
To view, visit http://gerrit.ovirt.org/1015
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac296e9a2c2ebd5ba28d1ba852a37054f1193c4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
