Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 30: protected boolean canDoAction() {
It is code stile will not provide any benefit . Possible in next rebse will
update
Line 44: .contains(getVm().getguest_os().toLowerCase())) {
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java
Line 13: public class HotUnPlugDiskFromVmCommand<T extends
HotPlugDiskToVmParameters> extends HotPlugDiskToVmCommand<T> {
Regards signature agreed regards inheritance hierarchy , I did not understand
your comment. I will not create a new class for un plug parameters it is the
same as parameters for plug command - this is idea of inheritance as I
understand. it would allow the use of an unplug command in place of a plug
command - I don't understand how, HotUnPlugDiskFromVmCommand - it is a
different class
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotUnPlugDiskVDSCommand.java
Line 5: public class HotUnPlugDiskVDSCommand<P extends
HotPlugDiskVDSParameters> extends HotPlugDiskVDSCommand<P> {
Done
--
To view, visit http://gerrit.ovirt.org/1019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3190a8f82c7abee7af2ab470b37a2cdc36009d9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
