Dan Kenigsberg has posted comments on this change. Change subject: agent: added a support for a guest hibernate command. ......................................................................
Patch Set 1: (2 inline comments) .................................................... File ovirt-guest-agent/GuestAgentLinux2.py Line 3: # Copyright 2010 Red Hat, Inc. and/or its affiliates. happy new year! Line 51: subprocess.call(cmd) general comment: it would be nicer to log the output/error/returncode of external script but what's the point of running this as an external script? why not a local function? -- To view, visit http://gerrit.ovirt.org/1122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic360fa47576121dd7c9e3bddcf758843cb1847b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <gham...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
