Eli Mesika has posted comments on this change.
Change subject: core: Adding hash column to Views/SPs and DAL
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File backend/manager/dbscripts/create_views.sql
Line 377: vm_static.initrd_url as initrd_url,
vm_static.kernel_url as kernel_url, vm_static.kernel_params as kernel_params,
vm_dynamic.pause_status as pause_status, vm_dynamic.exit_message as
exit_message, vm_dynamic.exit_status as exit_status,vm_static.migration_support
as migration_support,vm_static.predefined_properties as
predefined_properties,vm_static.userdefined_properties as
userdefined_properties,vm_static.min_allocated_mem as min_allocated_mem,
vm_dynamic.hash as hash
already answered
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
Line 124: @Column(name = "hash")
should be discussed and implemented separately
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 745: @XmlElement(name = "guest_requested_memory")
fixed
if it is not relevant , all should be removed in a separate patch
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
Line 110: .addValue("hash", vm.getHash());
answered
--
To view, visit http://gerrit.ovirt.org/1153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea0bcf8fc2c03a3431c6b80bef61db84f1d2dca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
