Livnat Peer has posted comments on this change.
Change subject: engine : Added option to call some methods of lock util over JMX
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(14 inline comments)
ack for the patch logic.
I fixed some comments and a file that is empty should not be part of the patch.
After fixing the messages you can push, no need for another review cycle.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java
Line 130: log.warn("All in memory locks are going to be cleaned");
"Cleaning all in memory locks"
Line 142: log.warn("A following key are going to be released via
external call, keyId : " + lockId);
The message should be:
"The following lock is going to be released via external call, lockId {0} " ,
lockId
Line 147: log.warn("A lock with id : " + lockId + " is not
exist and can not be release via external call");
"Lock with id {} does not exist and can not be released via external call"
Line 159: log.warn("A following key was released via external call,
keyId : " + lockId);
" Lock {0} was released via external call" , lockId
Line 166: log.warn("All in memory locks will be shown");
please change this log message to debug
Line 177: log.warn("All in memory locks were shown");
please change this log message to debug
Line 203: log.debugFormat("Failed to acquire a lock
because of shared lock - key :{0} and value {1}",
Failed to acquire lock. Shared lock is taken for key :{0} , value: {1}
Line 213: log.debugFormat("Failed to acquire a lock
because of exclusive lock - key :{0} and value {1}",
Failed to acquire lock. Exclusive lock is taken for key: {
0} , value: {1}
Line 222: log.debug("Successed to acquire a lock");
"acquiring lock {0} succeeded ", lock
Line 268: log.warnFormat("Trying to release exclusive lock which is
not exist with for {0}", key);
Trying to release exclusive lock which does not exist, lock key: {0}", key
Line 270: log.warnFormat("Trying to release exclusive lock which is
not exclusive lock for key {0}", key);
Trying to release exclusive lock but lock is not exclusive. lock key: {0}", key
Line 285: log.warnFormat("Trying decrease shared lock index
which is 0 is for key {0}", key);
the message should be:
"Trying to decrease a shared lock for key: {0} , but shared index is 0"'
Line 288: log.warnFormat("Trying release shared lock which is not
exist for key {0}", key);
the message should be: "Trying to release a shared lock for key: {0} , but lock
does not exist."
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockManager.java
Line 3:
why is this file part of the patch?
--
To view, visit http://gerrit.ovirt.org/1042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43183d2c68fba805dadcfe8225977cc2565423d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
