Doron Fediuck has posted comments on this change. Change subject: core : Adding utility class for VmDevice - VmDeviceUtils ......................................................................
Patch Set 3: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 15: private final static String HIGH_VIDEO_MEM = "65536"; Can we put these numbers in config (DB)? Line 71: DbFacade.getInstance().getVmDeviceDAO().remove(list.get(0).getId()); This is assuming only once CD is allowed, right? If this is the case please document it in the code, so we'll know where to fix it... Line 228: device.setBootOrder(bootOrder++); This is actually adding functionality, since in 3.0 only system-disk is bootable. I think method should have an oldAPI flag, and in such a case break on the first system-disk and skip non-system disks. -- To view, visit http://gerrit.ovirt.org/1164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4956e963f46491be7c72804cceb76eee40838037 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
