Yair Zaslavsky has posted comments on this change.
Change subject: engine: IPA does not perform login with UPN (#783662)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java
Line 29: public static final String RHDS_VENDOR_NAME = "Red Hat";
I would suggest this be an enum of VendorName.
I know there are only two now, but already thinking of possible future cases :)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/RootDSEData.java
Line 45: if
(vendorName.equals(RootDSEQueryInfo.IPA_VENDOR_NAME)) {
This code is repetitive. Appears also in previous file in your patch (the if...
part).
Please think of possible code reuse.
--
To view, visit http://gerrit.ovirt.org/1200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf5e4619dcbc08055eee4d2ae126c22707fe41a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
