Eli Mesika has posted comments on this change. Change subject: engine: allow search events by object id ......................................................................
Patch Set 2: (4 inline comments) have added Einav to check if we need any code changes at the client side as well. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java Line 377: * @author lhornyak please remove author signature .................................................... File frontend/api/genericapi/pom.xml Line 63: <extraJvmArgs> -Xmx1024M -XX:PermSize=256M -XX:MaxPermSize=256M</extraJvmArgs> This file change is not relevant for the patch , please remove from patch set .................................................... File frontend/webadmin/modules/sharedgwt/pom.xml Line 17: <gwt-plugin.extraJvmArgs>-Xmx1024M -XX:PermSize=256M -XX:MaxPermSize=256M</gwt-plugin.extraJvmArgs> Same , IMHO not related to this patch .................................................... File frontend/webadmin/modules/uicommonweb/pom.xml Line 18: </properties> Why this change is related to the Search mechanism code changes??? -- To view, visit http://gerrit.ovirt.org/1241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ca6288d256d3722023d9b7119417dc94ebdbe9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
