Maor Lipchuk has posted comments on this change.

Change subject: core: Task Manager Add Jobs handling on server startup
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 221:             JobRepositoryFactory.getJobRepository().finalizeJobs();
Please add log here before and after calling the finalize jobs, it could help 
spot dead locks, if occurs.

I think, there will be a problem tracking uknnown job life cycle,
there is no indication which jobs are being set to 'unknown' and when.
 maybe consider updating the lastUpdateTime in the Job entity, and from that we 
can conclude on the rest of the steps.

--
To view, visit http://gerrit.ovirt.org/1087
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5d7987e75de20775d0d8e99278741baf6af907
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to