Ronen Angluster has posted comments on this change.
Change subject: Packaging: Updated release definition (#784425)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
see inline comments
....................................................
File Makefile
Line 21: #RPM_RELEASE:=$(shell echo $(APP_VERSION) | awk -F\. '{print
$$3"%{?dist}"}')
please remove this remarked line if its not necessary (or add a comment about
why is it remarked)
Line 63: sed 's/^Release:.*/Release: $(RELEASE_VERSION)%{?dist}/'
$(SPEC_FILE).1 > $(SPEC_FILE)
why not combine the 2 lines into 1 sed action (-e 'regex' -e 'regex') ?
--
To view, visit http://gerrit.ovirt.org/1318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f45b2c8a7231dce5022d7fac0b5a019976ab221
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ronen Angluster <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
