Moti Asayag has posted comments on this change. Change subject: webadmin: Adding a Cache to the AsyncDataProvider ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java Line 75: ManagementNetwork; shouldn't it also be configured in ovirt-engine/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java ? .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java Line 91: private static java.util.HashMap<java.util.Map.Entry<ConfigurationValues, String>, Object> CachedConfigValues = Is there any reason to specify the full package qualifier of java.util.HashMap ? -- To view, visit http://gerrit.ovirt.org/1409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52a6827d5ad9d1c68c5b76b5288a63ece324c302 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Danny Rankevich <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Danny Rankevich <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
