Livnat Peer has posted comments on this change.
Change subject: core: Adding DefaultOriginType config value
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
I would use another key for this value. other that ack
....................................................
File backend/manager/dbscripts/upgrade/03_01_0250_add_default_origin_type.sql
Line 1: select fn_db_add_config_value('DefaultOriginType','OVIRT','general');
why use DefaultOriginType and not OriginType, this is not a value the user can
override with non-default value.
--
To view, visit http://gerrit.ovirt.org/1621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I743811f11c3f9f5582af186484d5685dfebc4c2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
