Omer Frenkel has posted comments on this change.

Change subject: engine: Quota upgrade script
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/dbscripts/upgrade/03_01_0280_quota_upgrade_script.sql
Line 76:       END LOOP;
isnt the above code equals to:
UPDATE vm_static set quota_id = quota_uuid where vm_guid in 
        (select vm_static.vm_guid as vm_guid
        FROM vds_groups,vm_static
        WHERE storage_pool_id = cur.id and vm_static.vds_group_id = 
vds_groups.vds_group_id)

if so i think its better to use simple sql for simple stuff

--
To view, visit http://gerrit.ovirt.org/1562
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82669e1f8e528a1a9c75e1999c2ca4d3a56fddb6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to