Yair Zaslavsky has posted comments on this change. Change subject: core: Introduce notion of internal queries ......................................................................
Patch Set 3: (1 inline comment) Looks good, minor comment .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java Line 316: command.setInternalExecution(!isPerformUserCheck); I wonder if this is always the rule for whether internal execution should be used. Maybe we should consider introducing a boolean method of "isInternalExecution()" or something like that, that currently will run the code you provided ? (i.e - return !isPerformUserCheck()) -- To view, visit http://gerrit.ovirt.org/1386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11e9977b58cee2d919c44d6940daeee2a3ff7da3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
