Yair Zaslavsky has posted comments on this change.

Change subject: core: Checking permissions when executing queries
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java
Line 109:     @Test
You can do that more nicely, using @Parameters annotation of junit. We have a 
test at utils.json for that (JsonEntitiesTest, IIRC).

--
To view, visit http://gerrit.ovirt.org/1585
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04f4ef1b28146ac844ec1955b9c9ecfed12039c6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to