Michael Kublin has posted comments on this change. Change subject: core: Cleanup on SessionDataContainer ......................................................................
Patch Set 8: You missed test which is testing : SetData(String sessionId, String key, Object value). GetData(String sessionId, String key, boolean refresh). removeSession() removeSession(String sessionId) cleanExpiredUsersSessions() If you writing test please write for everyone , and not only for the case that uses ThreadLocalParamsContainer. Please change commit message, it is not relevant -- To view, visit http://gerrit.ovirt.org/1315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9db31711b372c16d87bf19c4fb573aaec56c9823 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
