Jonathan Choate has posted comments on this change.

Change subject: engine-core: Move disk command
......................................................................


Patch Set 2: (12 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDiskCommand.java
Line 33:         super(parameters);
Done

Line 37:         targetDomainValidator = new 
StorageDomainValidator(getParameters().getDestinationDomain(), 
getParameters().getStoragePoolId());
Done

Line 47:         vmIsDown() &&
Done

Line 60:     protected void executeCommand() {
Done

Line 61:         VmHandler.LockVm(getVm().getDynamicData(), 
getCompensationContext());
Done

Line 100: 
Done

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transaction/MoveOrCopyImageGroupTransaction.java
Line 11: 
Done

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
Line 13: 
Done

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
Line 65:             Map<storage_domains, Integer> map = new 
HashMap<storage_domains, Integer>();
Done

Line 68:                     storage_domains domain = entry.getValue();
Done

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveDiskParameters.java
Line 6: 
Done

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
Line 626: 
Done

--
To view, visit http://gerrit.ovirt.org/1608
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e3eddcf7b00c65440eac76f141de1e5ba83c675
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Jonathan Choate <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to