Eyal Edri has posted comments on this change. Change subject: packaging: classify params and groups (plugins step 1/3) ......................................................................
Patch Set 4: (2 inline comments) .................................................... File packaging/fedora/setup/engine-setup.py Line 27: from engineparams import Group engine_params looks clearer IMO Line 324: } it will much better if we could export this class to an external conf/def file. also, i would try and think on way to dynamically create this data structure via loop and not manually like this. -- To view, visit http://gerrit.ovirt.org/1626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fea2cb92a7f9c0b2447ca106262c973918fa7d0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Idan Mansano <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ronen Angluster <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
