Doron Fediuck has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Hi Dan, thanks.
This is still not ready to be submitted. See inline remark-
you need to create another sql file.
Also, if you're into cleanups, we have use-vdc-repo which is
no longer relevant just as well. See if you want to handle it.
....................................................
File backend/manager/dbscripts/fill_config.sql
Line 103
This file cannot be edited.
Instead, you should create an upgrade sql script;
backend/manager/dbscripts/upgrade/03XXX_drop_netconsole.sql
select fn_db_delete_config_value('NetConsolePort','general');
--
To view, visit http://gerrit.ovirt.org/1689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7aee6999d08e43bf8059b53388b68912e393193
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
