Michael Pasternak has posted comments on this change.

Change subject: sdk: Add HTTP request and response hooks.
......................................................................


Patch Set 3: Do not submit

(2 inline comments)

....................................................
File src/ovirtsdk/infrastructure/proxy.py
Line 21: 
unless there's a strong requirement for this in production environment
(not for testing purpses) - I'm NAKing this patch

Line 42: 
SDK already has logging capabilities (they will be exposed to user in next 
version),
so this code is redundant

--
To view, visit http://gerrit.ovirt.org/1649
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52562f96039d416e3e728406ddd1b95d4db04ac7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Jaroslav Henner <jhen...@redhat.com>
Gerrit-Reviewer: Jaroslav Henner <jhen...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to