Omer Frenkel has posted comments on this change. Change subject: engine: Create default unlimited quota for DC ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java Line 33: getStoragePool().setQuotaEnforcementType(QuotaEnforcmentTypeEnum.DISABLED); what if the user sent another enf. type in the params? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java Line 43: storage_pool storagePool = DbFacade.getInstance().getStoragePoolDAO().get(getStoragePool().getId()); why getting this again and not using _oldStoragePool -- To view, visit http://gerrit.ovirt.org/1334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib963feff1216b4792b5981e602b4aea96149207e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
