Moti Asayag has posted comments on this change. Change subject: core : Clean up of Vm related commands ......................................................................
Patch Set 1: Looks good to me, approved (4 inline comments) minor typo comments. A gratitude from findbug for this patch .................................................... Commit Message Line 11: 1. Method setVmId() was moved from all child classes to parent class (I think these is idea of inheritnce) inheritnce --> inheritance Line 13: 3. Added serialVersionUID Is there any reason why the commands should be serializable? Line 14: 4. At some classes removed unused varaibles. varaibles --> variables Line 15: 5. MergeSnapshot - removed uneeded logic, for vm retrieving uneeded --> unneeded -- To view, visit http://gerrit.ovirt.org/1718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5db61da404245f04f131f757a4a2fcae7f22172 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
