Danny Rankevich has posted comments on this change.
Change subject: webadmin: integarating report into webadmin
......................................................................
Patch Set 4: (6 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
Line 68: private Model modelBoundWidget;
please rename member and methods name to" widgetModel"
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
Line 96: public static class ReportCommand extends UICommand {
please move this class to a separate file
Line 464: reportModel.setReportStartDate(new Date(2011, 8, 1));
add TODO comments for this code, since it must be implemented in the final
version
Line 477: protected void setReportModelResourceId(ReportModel reportModel,
String idParamName, boolean isMultiple) {
please imlement a different method:
String getItemId(Object)
that returns the report ID for a specific item
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/ReportsHelper.java
Line 43: // parse the XML document into a DOM
this should be a call to a URL, and not a compiled resource file.
in addition, make sure to handle a situation where there is no report server
installed, and add a flag that shows whether the reports are enabled or not
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/Reports.xml
Line 17: <resource type="Host" id="P_Host_ID" multiple="false">
please change "id" attribute to "idParamName"
--
To view, visit http://gerrit.ovirt.org/1702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7695e6ac420b76fd1cc5faaf79a1a7f9909f20d4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Danny Rankevich <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
