Omer Frenkel has posted comments on this change.
Change subject: engine: Add/edit quota commands
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
Line 49: VdcObjectType.Quota);
if you give storage pool id, you need to give storage pool object type, or the
object wouldn't be found
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 48: return Collections.singletonMap(getStoragePoolId() == null ?
null : getStoragePoolId().getValue(),
here i think the quota id should be returned
Line 63: private void setQuotaParameter(T parameters) {
its hard to say but looks like this is the same code as in the add command...
--
To view, visit http://gerrit.ovirt.org/1328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d932a312a51aafb9c4f80a549314b3c53890841
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
