Omer Frenkel has posted comments on this change. Change subject: engine: Add quota CRUD commands to vdcActionType ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java Line 167: AddQuota(601, ActionGroup.CONFIGURE_QUOTA), i think there should be a different action group for add and for edit/remove, usually we give add permission on the parent object (storage pool) and configure permission on the object itself (look at add/update/remove cluster - although there the remove is separated as well, not sure needed here) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java Line 5: no need to push this -- To view, visit http://gerrit.ovirt.org/1744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ad383c055de6c2b37096517cc72c09beeac553 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
