Mike Kolesnik has posted comments on this change. Change subject: core: DO NOT SUBMIT db scripts for removing disk image template ......................................................................
Patch Set 4: (3 inline comments) .................................................... File backend/manager/dbscripts/create_views.sql Line 72: JOIN disks ON images.image_group_id = disks.disk_id JOIN vm_device on vm_device.device_id = images.image_guid join vm_static on vm_static.vm_guid = vm_device.vm_id; Probably VM_DEVICE should be LEFT OUTER JOIN'ed since we plan to support floating disks. You should talk about it with mlipchuk maybe he will do it later when he adds this support. .................................................... File backend/manager/dbscripts/upgrade/03_01_0320_remove_image_templates_table.sql Line 1: insert into images (image_guid,creation_date,size,description,boot,it_guid,internal_drive_mapping) select it_guid,creation_date,size,description,bootable,it_guid,internal_drive_mapping from image_templates; If the data in image_templates already a duplicate of the original data, why would you try to re-insert it? I suspect this will fail on PK violations.. Line 2: ALTER TABLE images add CONSTRAINT image_templates_images FOREIGN KEY(it_guid) REFERENCES images(image_guid); Won't this collide with the existing constraint? -- To view, visit http://gerrit.ovirt.org/1565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83885966ca8c187351623acbe502cb6ce218e2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
