Michael Pasternak has posted comments on this change.

Change subject: restapi: Fix RSDL List-Parameters Display
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 7: restapi: Fix RSDL List-Parameters Display
it's not fix, but adding support for parameters of type Collection

Line 17: 
it doesn't compiles:

[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java:[10,38]
 cannot find symbol
symbol  : class LogCompat
location: package org.ovirt.engine.core.utils.log

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java:[11,38]
 cannot find symbol
symbol  : class LogFactoryCompat
location: package org.ovirt.engine.core.utils.log

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java:[17,27]
 cannot find symbol
symbol  : class LogCompat
location: class org.ovirt.engine.api.restapi.utils.TypeConversionHelper

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java:[12,38]
 cannot find symbol
symbol  : class LogCompat
location: package org.ovirt.engine.core.utils.log

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java:[13,38]
 cannot find symbol
symbol  : class LogFactoryCompat
location: package org.ovirt.engine.core.utils.log

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java:[17,27]
 cannot find symbol
symbol  : class LogCompat
location: class org.ovirt.engine.api.restapi.types.DateMapper

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java:[17,43]
 cannot find symbol
symbol  : variable LogFactoryCompat
location: class org.ovirt.engine.api.restapi.utils.TypeConversionHelper

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java:[69,21]
 cannot find symbol
symbol  : method setPlugged(java.lang.Boolean)
location: class org.ovirt.engine.core.common.businessentities.DiskImage

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java:[111,31]
 cannot find symbol
symbol  : method getPlugged()
location: class org.ovirt.engine.core.common.businessentities.DiskImage

/home/mpastern/Coding/ovirt/ovirt-engine/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java:[17,43]
 cannot find symbol
symbol  : variable LogFactoryCompat
location: class org.ovirt.engine.api.restapi.types.DateMapper

--
To view, visit http://gerrit.ovirt.org/1831
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5dccb1ee80927dbc13ed0ce3cfff9e4f4c78d10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to