Roy Golan has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
......................................................................
Patch Set 12: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
Line 180: : Config.<Integer>
GetValue(ConfigValues.vdsTimeout);
the added timeout to make the poll command return quickly(its sole usage is for
generating traffic). If the poll call will have the same timeout as the
setupnetworks call, then I will have only one chance to poll :( - the poll
is crucial to make the VDSM understand the network is working and commit the
new changes
Line 187: log.debug("Setup networks command timed out for " +
timeout + " seconds");
Done
Line 235: log.debug("polling host " + getVdsName());
Done
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java
Line 18: httpTask = getBroker().poll();
the return value is calculated once the caller is using the get() method.
--
To view, visit http://gerrit.ovirt.org/880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I340df50a5889cb57b9919079d196f3d950e5272d
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
