Omer Frenkel has posted comments on this change. Change subject: engine: Add quota validation to commands ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 97: protected Guid commandId = Guid.NewGuid(); i think its better to keep it private and add a protected getter. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java Line 360: getParameters().getQuotaId(), why quota is taken from the parameters? shouldn't it be taken from the vm? i thought that the quota is defined on vm creation, not per run. .................................................... Commit Message Line 11: resource when creatinmg new disks. typo creatinmg->creating -- To view, visit http://gerrit.ovirt.org/1750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1547b54e173ab101cc65a30313a077fea528f65a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
