Yair Zaslavsky has posted comments on this change. Change subject: core: VM implements BusinessEntity ......................................................................
Patch Set 1: (4 inline comments) Please explain the motivation for this patch, and address my comments. .................................................... File frontend/webadmin/modules/gwt-extension/src/META-INF/MANIFEST.MF Line 2: Class-Path: Whitspace introduced. fix this. .................................................... File frontend/webadmin/modules/sharedgwt/src/main/java/engine-common-context.xml Line 7: http://www.springframework.org/schema/beans/spring-beans-3.0.xsd What's that and why does it have to do in this patch? .................................................... File frontend/webadmin/modules/uicommonweb/bin/pom.xml Line 3: 1. Why was this introduced? 2. There is a whitespace. .................................................... File frontend/webadmin/modules/uicommonweb/bin/src/main/java/org/ovirt/engine/ui/UICommonWeb.gwt.xml Line 7: Whitespace introduced. Please fix (and why was this introduced in this patch?) -- To view, visit http://gerrit.ovirt.org/1847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c7449639b2d71ac8c2415e588d53e6a8bd8c609 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
