Ronen Angluster has posted comments on this change. Change subject: virt-engine: Support RHEVManager url ......................................................................
Patch Set 9: Fails; I would prefer that you didn't submit this (3 inline comments) see inline. .................................................... File packaging/fedora/setup/common_utils.py Line 145: def nodeExist(self, urn, node): why do we need this method? .................................................... File packaging/fedora/setup/engine-setup.py Line 2126: virtualServerNS = '//web:subsystem/web:virtual-server' That is not a namespace but a xpath xml path. please change the variable name since it is misleading. Line 2128: if not xmlObj.nodeExist(virtualServerNS, rewriteNode): why not simply remove the node (which wont do a thing if the node does not exist)? This will fail if the node you're searching for have any nested nodes on it: compare rewriteNode with searched node. if they are not the same(which will be the case if we have nested nodes) try to add the new "rewrite" node, which already exists. -- To view, visit http://gerrit.ovirt.org/1120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3ce188155bda87f5cc106e2a6c2408fb0da790 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ronen Angluster <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
