Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding snapshots STPs & DAO
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File backend/manager/dbscripts/create_functions.sql
Line 9: DROP TYPE IF EXISTS booleanResultType CASCADE;
Not understood from commit message why you need this. I hope I will understand
later, but maybe worth mentioning in commit message?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java
Line 62: return new ParameterizedRowMapper<Snapshot>() {
Following my email to engine-devel - can we return each time the same single
instance of this mapper? (If you introduce a new DAO, and we know this will
save us some "new" operations - why not save them from beginning?)
--
To view, visit http://gerrit.ovirt.org/1966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie79357769c5bfe6adaaeb719a243337b32d2c39e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
