Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Common widget UI reuse, part two ......................................................................
webadmin: Common widget UI reuse, part two Moving even more common widgets from WebAdmin into GwtCommon, along with corresponding resources. Widgets that were extracted into GwtCommon: - tab widgets SimpleTab, ModelBoundTab - UiCommon support widgets TogglePanel - form display widgets GeneralFormPanel - other widgets Slider Note: tab panel widgets, such as SimpleTabPanel or HeadlessTabPanel, were not extracted, since their UiBinder templates appear to differ from each other. Since they all inherit from AbstractTabPanel, this shouldn't be an issue (but we can move them into GwtCommon later and verify that this change has no impacts on application UI). Change-Id: Iea0a435d4e5781823102d15af1839cea8751242f --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/TogglePanel.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/Slider.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/Slider.ui.xml R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/SimpleTab.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/SimpleTab.ui.xml R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/dialog_header_background_repetitive.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/main_tab_left.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/main_tab_middle.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/main_tab_right.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/tab_arrow_selected.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/tab_left_selected.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/tab_middle_selected.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/tab_right_selected.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPolicyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPolicyPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tab/TabFactory.java 36 files changed, 48 insertions(+), 51 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea0a435d4e5781823102d15af1839cea8751242f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Danny Rankevich <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
