Ronen Angluster has posted comments on this change. Change subject: packaging: Add engine-upgrade utility ......................................................................
Patch Set 1: I would prefer that you didn't submit this (4 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 562: # TODO: Support SystemD services In Fedora 16 the command "service whatever stop/start/anything" is automatically forwarded to systemctl. .................................................... File packaging/fedora/setup/engine-setup.py Line 1649: cmd = "%s -q %s >> %s"%(basedefs.EXEC_RPM, basedefs.RPM_LOCK_LIST, basedefs.FILE_YUM_VERSION_LOCK) In genenral this is a bad idea for a command. if you want to append it to a file. do it yourself (i.e. take the output of stdout and append it to the file) Line 1650: output, rc = utils.execExternalCmd(cmd, True, output_messages.ERR_YUM_LOCK) why not utils.execCmd ? .................................................... File packaging/fedora/setup/engine-upgrade.py Line 155: cmd = [basedefs.EXEC_SERVICE, JBOSS_SERVICE_NAME, "status"] Please remove all white spaces from this file. -- To view, visit http://gerrit.ovirt.org/1801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bac004c8a8bf93f9b3d3bc7e2efe5b0ec2823a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Ronen Angluster <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
