Danny Rankevich has submitted this change and it was merged. Change subject: core: VDSGroup implements BusinessEntity ......................................................................
core: VDSGroup implements BusinessEntity no bz The business entities have common procedures- getId and setId. But as they don't have a common interface, each business entity has getId and setId methods of its own. Even the names of these methods in different business entities are not the same (some have getId other getID and ect.) In this patch I added to the VDSGroup implemented interfaces- BusinessEntity inteface. In VDSGroup- refactoring getID() to getId() and setID(...) to setId(...). Change-Id: Idd48e8eb3d63bb5e0fa334c625e2e342dc598fca --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsGroupOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkClusterDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTestCase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClustersResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/Cloner.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/DataProvider.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/Linq.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/SystemTreeModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/hosts/AddClusterRM.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/hosts/HostModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/userportal/UserVmModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/users/UserListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/UserPortalExistingVmModelBehavior.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmListModel.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModel.java M frontend/webadmin/modules/userportal/src/main/java/org/ovirt/engine/ui/userportal/client/binders/ObjectNameIdResolverFactory.java 73 files changed, 234 insertions(+), 193 deletions(-) Approvals: Danny Rankevich: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd48e8eb3d63bb5e0fa334c625e2e342dc598fca Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Danny Rankevich <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
