Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Simplifyed generics on editors ......................................................................
webadmin: Simplifyed generics on editors When the editor delegates are generated, the GWT assignes them a name like this: editorName_genericArg1_genericArg2_..._UiCommonModelEditorDelegate.java As the genericArg is a fully qualified name of the class which is the generic argument, the length of the filename can grow to be quite big. As the filesystems has a limit to the length of the files names (e.g. ext4 can have max 256B long filenames only) it can happen that the size of the file can exceed the allowed length for the specific file system. This was a particular problem with WidgetWithLabelEditor when when I needed to generalize the EntityModelCheckBoxEditor to BaseEntityModelCheckBoxEditor, the resulting file name looked like this: WidgetWithLabelEditor_org_ovirt_engine_ui_uicommonweb_models_vms_ ConsoleModel_org_ovirt_engine_ui_common_widget_editor_ TakesValueWithChangeHandlersEditor_org_ovirt_engine_ui_common_widget_ editor_BaseEntityModelCheckboxEditor_UiCommonModelEditorDelegate.java which is too long to be stored on ext4 (or ext3, NTFS, FAT...) The solution was to simplify the WidgetWithLabelEditor to have less generic arguments so the resulting filename will be shorter. This patch contains only the generic arguments simplification, not the generalized BaseEntityModelCheckBoxEditor. Change-Id: I10354757de370e0b7b036c52150758bc64bfa2f2 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/AbstractValueBoxWithLabelEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCheckBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelRadioButtonEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EntityModelSliderWithTextBoxEditor.java 7 files changed, 28 insertions(+), 28 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10354757de370e0b7b036c52150758bc64bfa2f2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Danny Rankevich <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
