Danny Rankevich has posted comments on this change.
Change subject: webadmin: integrating reports to webadmin (commnets fixes)
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
Line 458: if (reportCommand.getIdParamName() != null) {
consider adding an assert item instanceof BusinessEntity
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
Line 47: AsyncDataProvider.GetRedirectServletReportsPage(new
AsyncQuery(this,
please move this tot he init() method
Line 271: reportsInitEvent.raise(this, null);
i would add a comment like:
// the initialization process blocks on this event after the login
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
Line 51: public void eventRaised(Event ev, Object sender, EventArgs
args) {
please call super.onLogin() here since this is the same code
--
To view, visit http://gerrit.ovirt.org/1952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e4ef27904774073173cabe41f70051f4ce1d60b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Danny Rankevich <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
