Omer Frenkel has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
......................................................................
Patch Set 3: (7 inline comments)
....................................................
File backend/manager/dbscripts/multi_level_administration_sp.sql
Line 407:
looks like this change is not needed
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 477: protected boolean checkUserAuthorization(final ActionGroup
action, final Guid object, final VdcObjectType type) {
please rename action to action group
Line 554: return true;
we dont want to return if quota check passed, just continue to check next
subjects
Line 597: log.warnFormat("Quota id was not set to consume from
Data Center {0}", storagePoolName);
if (log.isDebugEnabled()) {
log.debugFormat("quota id was not set, can't check consumption for data center
{0} action: {1}",storagePoolName,getActionType());
}
Line 600: log.warnFormat("Quota user is not permitted to
consume from Data Center {0}", storagePoolName);
if (log.isDebugEnabled()) {
log.debugFormat("user is not permitted to consume from quota {0} in data center
{1} for action {2}",objectId,storagePoolName,getActionType());
}
Line 611: return true;
else if (!isPermitted && quotaEnforcement ==
QuotaEnforcmentTypeEnum.HARD_ENFORCEMENT)
{
609 return false;
610 }
611 return true;
can be replaced with:
return isPermitted;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
Line 231: public NGuid getQuotaPermissions(Guid adElementId, Guid objectId,
should be removed?
--
To view, visit http://gerrit.ovirt.org/2108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7311edd8fadeffcea920e2e0eac02496f3d6e0c7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
