Allon Mureinik has posted comments on this change. Change subject: core: Cleanup GetAllVmSnapshotsByDriveQuery ......................................................................
Patch Set 9: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByDriveQuery.java Line 31: getQueryReturnValue().setReturnValue(new ArrayList<DiskImage>()); Perhaps in an additional future cleanup. new ArrayList() and Collections.emptyList() have different behavior (one is immutable and one isn't). Don't want to start hunting down usages right now, in this patch. -- To view, visit http://gerrit.ovirt.org/1910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e7987a4581b35aa9645b37096037319b9af2624 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
