Oved Ourfali has posted comments on this change. Change subject: core: set spec_params correctly when creating vm from template ......................................................................
Patch Set 1: (1 inline comment) See minor comment. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 369: sb = new StringBuilder(appendDeviceIdToSpecParams(newId, sb.toString())); Looks like you just need a new String (and the method returns one), and not a StringBuilder. Just get the String, and use it afterwards. -- To view, visit http://gerrit.ovirt.org/2233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295fe371e019fa83e9a14316e3864cef2153d28a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
