Moti Asayag has posted comments on this change. Change subject: core : Removing image_group_storage_domain table - engine core ......................................................................
Patch Set 4: Verified; Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java Line 113: getDisksList().get(0).getstorage_ids().get(0), not related to this patch, but running getDisksList() twice in the canDoAction is paying extra DB access, same for calling it from within the executeCommand() -- To view, visit http://gerrit.ovirt.org/2212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f197a5c06603f0fb36ec495c010a8e5bfe360ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
